Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs in template, fix kubectl apply command in docs #185

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ncopa
Copy link
Contributor

@ncopa ncopa commented Apr 11, 2024

Description

  • fix the URLs in example template
  • fix kubectl apply command for kubernetes quickstart

Why is this needed

Give a good impression to new users.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

ncopa added 2 commits April 11, 2024 16:09
Signed-off-by: Natanael Copa <[email protected]>
This is similar to what is in vagrant quickstart docs.

Signed-off-by: Natanael Copa <[email protected]>
@ncopa
Copy link
Contributor Author

ncopa commented Apr 11, 2024

This supersedes #181

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ncopa !

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Apr 11, 2024
@mergify mergify bot merged commit 6fa4121 into tinkerbell:main Apr 11, 2024
5 checks passed
@ncopa ncopa deleted the fix-template branch April 11, 2024 18:40
ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this pull request Sep 7, 2024
## Description

- fix the URLs in example template
- fix kubectl apply command for kubernetes quickstart

## Why is this needed

Give a good impression to new users.

## Checklist:

I have:

- [x] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants